Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Set g.co/agent span attribute for Stackdriver exporter based library/version of node #525

Closed
draffensperger opened this issue Apr 15, 2019 · 2 comments · Fixed by #604
Closed

Comments

@draffensperger
Copy link
Contributor

draffensperger commented Apr 15, 2019

Currently when we convert from a data.TraceData structure to go.opencensus.io/trace.Span structures to send to actual exports in exporterwrapper.go, none of the properties from Node are used. See the Node proto for the agent.

At least for the Stackdriver exporter, we should follow the practice of the other Stackdriver exporters and write the g.co/agent attribute based on the Node.LibraryInfo that has the language and version info for the library that wrote the spans to the agent. That would allow users to understand
what library produced the spans in a particular trace in case it needs to be upgraded.

@draffensperger draffensperger changed the title Set span attribute for library/version used to write the span Set g.co/agent span attribute for Stackdriver exporter based library/version of node Apr 16, 2019
@flands
Copy link
Contributor

flands commented Jul 3, 2019

@draffensperger what is the latest on this?

@draffensperger
Copy link
Contributor Author

I have some draft code for this but need to brush it off and get it out. I'll plan to work on it over the next week or so. I am aiming to get this into both the OpenCensus and OpenTelemetry services.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants