Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPBL: Final list displays incorrectly in log view #362

Closed
slcw opened this issue Aug 31, 2021 · 9 comments
Closed

CPBL: Final list displays incorrectly in log view #362

slcw opened this issue Aug 31, 2021 · 9 comments
Assignees

Comments

@slcw
Copy link

slcw commented Aug 31, 2021

Re: v21.08(30) BL update

Queries blocked by "Combined Privacy Block Lists: Final (bongochong)" are attributed to "Dummy Label" with the catagory of "Header" when examining the blocked query in the log view.

Screenshot_20210831-040344_RethinkDNS-02

@ignoramous
Copy link
Collaborator

Heh, we ran a manual re-drive of the blocklist updates today, and looks like engs have been fiddling with things they shouldn't normally be. Taking a look...

@slcw
Copy link
Author

slcw commented Aug 31, 2021

It's more of annoyance than anything, so probably not a high-priority fix.

@ignoramous
Copy link
Collaborator

Thanks for your bugrepot :) Fixed in the latest blocklists release. Try a update / re-download (blocklist version remains unchanged).

Screenshot_20210901-134824~2

@slcw
Copy link
Author

slcw commented Sep 1, 2021

I reset and re-downloaded my blocklists, and the problem remains unchanged. Queries blocked by "CPBL: Final" are still being attributed to "Dummy Label" with the catagory "Header".

@ignoramous
Copy link
Collaborator

Surprising. Can you please check if that issue is fixed in the beta build v053f (only downloadable from the website): rethinkdns.com/downloads?

@slcw
Copy link
Author

slcw commented Sep 1, 2021

Installation of v053f seems to have fixed this problem, and also Issue #363, although I haven't yet tested every blocklist.

Two observations re: v053f

  1. The new layout where you have to click to open a window that shows the blocklists that are blocking a particular query is inelegant, and clunky. It was much better when the lists were displayed directly on the query details.
  2. Just as you now have a toggle to block each log entry, there should also be a toggle to whitelist the host. We gotta get that whitelisting functionality, and a second toggle on the query details screen would be perfect.

I'm going to do a more thorough test of my blocklists this afternoon, and will update you as needed.

@ignoramous
Copy link
Collaborator

ignoramous commented Sep 1, 2021

Thanks.

The new layout where you have to click to open a window that shows the blocklists that are blocking a particular query is inelegant, and clunky. It was much better when the lists were displayed directly on the query details.

This is a stop-gap (which I thought was in-line with UI of the Network Logs screen), we need to figure out a better way to show blocklists and let users disable / enable them right there on that screen; but UI changes are likely to take a back seat considering we've been wanting forever to integrate WireGuard (#52) and fix other issues relating to the network engine (#89) . Lets see.

Just as you now have a toggle to block each log entry, there should also be a toggle to whitelist the host. We gotta get that whitelisting functionality, and a second toggle on the query details screen would be perfect.

This is planned for v054. We intend to ship v054 within 2 to 3 weeks of releasing v053g (which is up next; may be this week, may be next).

I'm going to do a more thorough test of my blocklists this afternoon, and will update you as needed.

Sure, but v053f is a beta-quality release. We've refactored a bunch of things (#282 #354) which has broken some things (like #357 for ex), but fixed a tonne of other bugs (like #277).

@ignoramous ignoramous self-assigned this Sep 1, 2021
@slcw
Copy link
Author

slcw commented Sep 1, 2021

After monitoring a few hours of traffic, all the lists are working properly and the app is running like a well-oiled machine. The new lists (CPBL and Blocklist Project lists) are a great addition.

@ignoramous
Copy link
Collaborator

Glad. More improvements incoming. I am closing this issue (and the other one). Feel free to re-open if you think these were not sufficiently addressed. Thanks again for your patience and feedback. Appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants