Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet connectivity issues #277

Closed
ignoramous opened this issue Apr 26, 2021 · 3 comments
Closed

Internet connectivity issues #277

ignoramous opened this issue Apr 26, 2021 · 3 comments
Assignees
Labels
bug Something isn't working L100 Task level: 100
Milestone

Comments

@ignoramous
Copy link
Collaborator

I've hit internet drops with YouTube, Google Maps, and Telegram when other apps seemingly continue to work fine. This, peculiarly enough, has often happened on Mobile data (and never on WiFi).

Previous work on this #248 meant the app works hard to not restart the VPN in a bid to prevent leaking connections. Figure out if there's a race in how NetworkManager works with ConnectivityService because the API documentation explicitly warns of race when fetching Networks in the Callbacks?

Two possible workarounds whilst we figure out the root-cause:

  1. Provide users with a knob to choose if the app should restart the VPN on every connectivity change like NetGuard does? Enable it by default, even?
  2. May be the act of changing the underlying network on the VPN could be handed off to WorkManager to be done 5s and 10s after the fact whilst cancelling existing vpn work if any? Or may be, a simple android.os.Handler would suffice?
@ignoramous ignoramous added this to the v054 milestone Apr 26, 2021
@ignoramous ignoramous added bug Something isn't working L100 Task level: 100 labels Apr 26, 2021
@ignoramous
Copy link
Collaborator Author

@ignoramous
Copy link
Collaborator Author

ignoramous commented Jul 22, 2021

We could also perhaps make use of android.net.ConnectivityDiagnosticsManager to be notified of data-stalls and connectivity-probe reports on API Level 30+

@ignoramous
Copy link
Collaborator Author

#282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working L100 Task level: 100
Projects
None yet
Development

No branches or pull requests

2 participants