Add unpredictable chain of values to epoch message #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ictor/epoch-entropy
kobigurk
reviewed
Nov 14, 2020
kobigurk
approved these changes
Nov 14, 2020
There was a problem hiding this comment.
@mstraka100 LGTM!
I added a few more tests, made the epochs tests more extensive so that they verify public inputs as well and some renaming.
mstraka100
commented
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Identical to #183 merged with master and with relevant circuit code added. This PR makes epoch entropy values, derived from the epoch block header hash, available to the constraint system. It adds constraints to check that the entropy values form a chain. Entropy values are optional to support different versions of Celo. These constraints are designed to be trivially satisfied if the first epoch does not contain entropy. The entropy of the first and last epochs are hashed as part of the public input.
Tested
The multiple epochs tests were refactored, with additional cases added covering the uses of entropy in epoch blocks.
Related issues
#185