feat!: create native blob struct #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't added a maximum size check to the length of the signer. |
Co-authored-by: Rootul P <[email protected]>
rootulp
approved these changes
Jun 18, 2024
evan-forbes
approved these changes
Jun 18, 2024
Comment on lines
+101
to
+105
| if err != nil { | ||
| // TODO: we should look at having a go native BlobTx type | ||
| // that we have already verified instead of doing it twice here | ||
| panic(fmt.Sprintf("invalid blob %d: %v", idx, err)) | ||
| } |
| if err != nil { | ||
| // TODO: we should look at having a go native BlobTx type | ||
| // that we have already verified instead of doing it twice here | ||
| panic(fmt.Sprintf("invalid blob %d: %v", idx, err)) |
There was a problem hiding this comment.
[not blocking nit]
can we add add a comment to this issue to indicate that it requires that all blobs passed to it are valid?
either that or add a new method / break this api that allows for error handling. my personal preference is that we panic as high in the stack as possible as that makes the problem that much clearer.
cristaloleg
reviewed
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #72
Closes: #70
Note: this does not touch any of the share construction yet