Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a local blob type #70

Closed
cmwaters opened this issue Jun 12, 2024 · 0 comments · Fixed by #74
Closed

Add a local blob type #70

cmwaters opened this issue Jun 12, 2024 · 0 comments · Fixed by #74
Assignees
@cmwaters
Labels
WS: Maintenance 🔧

Comments

@cmwaters
Copy link
Collaborator 

          It seems we expect Blob to have valid namespace at that point? If so, we can avoid using exported constractor in favour of local(without validion) constractor. I will remove the need to return error here and:
  • Method will be be much easier to use without if err != nil ...
  • Won't need (b *Blob) RawNamespace() anymore

Originally posted by @walldiss in #68 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwaters cmwaters

Labels
WS: Maintenance 🔧
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: create native blob struct celestiaorg/go-square
2 participants
@cmwaters @evan-forbes