Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix docker builds for arm64 #2862

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Oct 19, 2023

Overview

Now, this is finally fixed
Ref: rollkit/local-celestia-devnet#63

Closes https://github.com/celestiaorg/devops/issues/527

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@github-actions github-actions bot added the external Issues created by non node team members label Oct 19, 2023
Dockerfile Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@Bidon15 Bidon15 added ci:docker Related to docker + dockerhub flow kind:ci CI related PRs docker Pull requests that update Docker code labels Oct 19, 2023
@Bidon15 Bidon15 self-assigned this Oct 19, 2023
@Bidon15
Copy link
Member Author

Bidon15 commented Oct 19, 2023

cc: @jcstein and @nashqueue - next releases with this will get us back on track in devX for linux arm64 users

@Bidon15 Bidon15 requested a review from MSevey October 19, 2023 13:32
Copy link
Contributor

@sysrex sysrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you found it

@walldiss walldiss merged commit db16322 into celestiaorg:main Oct 19, 2023
15 of 19 checks passed
@nashqueue
Copy link
Member

nashqueue commented Oct 19, 2023

Thnak you !
cc @gupadhyaya

evan-forbes pushed a commit to celestiaorg/celestia-app that referenced this pull request Oct 19, 2023
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
This PR fixes the mismatch of architectures in build stages
Same can happen in app like it happened for node

Ref: 

 - celestiaorg/celestia-node#2862
 - celestiaorg/devops#527


<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this pull request Aug 1, 2024
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview
This PR fixes the mismatch of architectures in build stages
Same can happen in app like it happened for node

Ref: 

 - celestiaorg/celestia-node#2862
 - celestiaorg/devops#527


<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docker Related to docker + dockerhub flow docker Pull requests that update Docker code external Issues created by non node team members kind:ci CI related PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants