Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix multiplatform builds #2725

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Oct 19, 2023

Overview

This PR fixes the mismatch of architectures in build stages
Same can happen in app like it happened for node

Ref:

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Comment on lines +4 to +5
ARG TARGETOS
ARG TARGETARCH
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[optional] it looks like ARGs can contain underscores, in which case this seems a bit easier to read but def not blocking

Ref:

https://docs.docker.com/engine/reference/builder/#understand-how-arg-and-from-interact

Suggested change
ARG TARGETOS
ARG TARGETARCH
ARG TARGET_OS
ARG TARGET_ARCH

@evan-forbes evan-forbes merged commit fc348bf into celestiaorg:main Oct 19, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants