feat!: add ShareVersion field to blob #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
reviewed
Nov 18, 2022
MSevey
reviewed
Nov 18, 2022
MSevey
reviewed
Nov 18, 2022
MSevey
reviewed
Nov 18, 2022
evan-forbes
approved these changes
Nov 18, 2022
Comment on lines
+910
to
+911
| // TestDataProto tests DataFromProto and Data.ToProto | ||
| func TestDataProto(t *testing.T) { |
cmwaters
pushed a commit
that referenced
this pull request
Sep 20, 2023
#890) (#927) * add a test to trigger the issue * add a fix (in particular, we track the sender when receiving a tx twice) * add a changelog * update fix and test wrt. v0.34.x --------- Co-authored-by: Daniel <[email protected]> Co-authored-by: Pierre Sutra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of celestiaorg/celestia-app#936 and takes the first option mentioned in celestiaorg/celestia-app#1028 (comment)