Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: expose the exact data used by bridge nodes #927

Closed
4 tasks
cmwaters opened this issue Jan 3, 2023 · 0 comments · Fixed by #940
Closed
4 tasks

rpc: expose the exact data used by bridge nodes #927

cmwaters opened this issue Jan 3, 2023 · 0 comments · Fixed by #940
Assignees

Comments

@cmwaters
Copy link
Contributor

cmwaters commented Jan 3, 2023

Summary

This issue comes from a slack conversation. As I understand it, bridge nodes in celestia-node subscribe and listen for block events. For each new block, they then query the commit and validator set at the height of the block in order to verify it and process it accordingly (rebuild the extended square). Not only is redundant data being passed over the wire i.e. LastCommit, Evidence, ResponseBeginBlock and ResponseEndBlock, but the process requires two extra network round-trips and additional retry and error handling logic on the celestia-node side. It is trivial if instead, celestia-core exposes the correct data contained in a single request.

Proposal

Create a new event

type SignedDataEvent struct {
    header types.Header
    commit types.Commit
    vals types.ValidatorSet
    data types.Data
}

and RPC endpoint

func SignedData(ctx context.Context, height *int64) (*ctypes.ResultSignedData, error)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
cmwaters pushed a commit that referenced this issue Sep 20, 2023
#890) (#927)

* add a test to trigger the issue
* add a fix (in particular, we track the sender when receiving a tx twice)
* add a changelog
* update fix and test wrt. v0.34.x

---------
Co-authored-by: Daniel <[email protected]>
Co-authored-by: Pierre Sutra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants