Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "feat: add square size field to data root tuple (#145)" #155

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jul 20, 2023

Overview

Closes #154

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id requested a review from adlerjohn July 20, 2023 08:58
@rach-id rach-id self-assigned this Jul 20, 2023
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know why the go wrapper is failing? it appears that it was regenerated, but perhaps we're using a different version in the CI?

@rach-id
Copy link
Member Author

rach-id commented Jul 20, 2023

Fixed :D setting up the environment is always a mess. I am thinking of creating a bunch of docker images, specific to each repository environment, with the right versions installed and all. So, that whenever someone has some environment issue, they just use the image to generate whatever is needed

@rach-id rach-id merged commit 972b5ce into master Jul 24, 2023
4 checks passed
@rach-id rach-id deleted the revert_square_size branch July 24, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the square size from the DataRootTuple
2 participants