feat: add square size field to data root tuple #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
reviewed
Apr 18, 2023
src/DataRootTuple.sol
Outdated
Comment on lines
14
to
15
| // Celestia original block size. | ||
| uint256 blockSize; |
There was a problem hiding this comment.
square size or block size? can we get more docs on the units or what this is?
There was a problem hiding this comment.
good catch, will update to square size
rootulp
reviewed
Apr 18, 2023
rootulp
changed the title
rootulp
reviewed
Apr 18, 2023
Co-authored-by: Rootul P <[email protected]>
evan-forbes
approved these changes
Apr 19, 2023
rootulp
approved these changes
Apr 19, 2023
3 tasks
adlerjohn
approved these changes
May 1, 2023
rach-id
added a commit
that referenced
this pull request
Jul 24, 2023
…#155) <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> Closes #154 ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As per the decision in #142, we need to add the block size to the data root tuple.
Checklist