-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for the DAVerifier #138
Conversation
0b8e0ec
to
c3cdff1
Compare
@adlerjohn Does it make sense to revive this PR? |
# Conflicts: # Makefile
# Conflicts: # wrappers/QuantumGravityBridge.sol/wrapper.go
@adlerjohn @evan-forbes As part of the fraud proof mechanism that will be used, we will need to have this DAVerifier wrapper around the NMT and binary merkle tree proofs to verify the inclusion proofs correctly. |
@@ -65,7 +65,7 @@ jobs: | |||
|
|||
- name: Check Go wrapper match | |||
run: | | |||
if [ "$(git diff --ignore-space-at-eol wrappers/QuantumGravityBridge.sol/wrapper.go | wc -l)" -gt "0" ]; then | |||
if [ "$(git diff --ignore-space-at-eol wrappers/QuantumGravityBridge.sol/wrapper.go wrappers/DAVerifier.sol/wrapper.go | wc -l)" -gt "0" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be done programmatically instead of hard-coding? E.g. by looping over CONTRACTS
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could definitely do that, but I am inclined towards having the makefile
also format the sol
files in that step, and check for the diff on the whole repo.
This way we would be able to also check if the sol
files are not well formatted and ask the contributor to format them.
What do you think about doing this in a subsequent PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sure, follow-up PR is fine
Overview
Closes #133
Depends on: #137 to be able to create the wrappersChecklist