Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and also format the sol files in Makefile and check for it in CI #158

Closed
rach-id opened this issue Jul 26, 2023 · 0 comments · Fixed by #159
Closed

Build and also format the sol files in Makefile and check for it in CI #158

rach-id opened this issue Jul 26, 2023 · 0 comments · Fixed by #159
Assignees
@rach-id
Labels
github_actions Pull requests that update Github_actions code

Comments

@rach-id
Copy link
Member

rach-id commented Jul 26, 2023 

          We could definitely do that, but I am inclined towards having the `makefile` also format the `sol` files in that step, and check for the diff on the whole repo.

This way we would be able to also check if the sol files are not well formatted and ask the contributor to format them.

What do you think about doing this in a subsequent PR?

Originally posted by @sweexordious in #138 (comment)
@rach-id rach-id self-assigned this Jul 26, 2023
@rach-id rach-id added the github_actions Pull requests that update Github_actions code label Jul 26, 2023
@rach-id rach-id mentioned this issue Jul 26, 2023
Merged
5 tasks
rach-id added a commit that referenced this issue Jul 26, 2023
@rach-id
ci: add solidity formatting check and tweak go wrappers CI check (#159)
67c81ce 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

Closes #158

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: add solidity formatting check and tweak go wrappers CI check celestiaorg/blobstream-contracts
1 participant
@rach-id