Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Small corrections for statistics tracking #424

Merged
merged 6 commits into from
Sep 14, 2023
Merged

Conversation

burgholzer
Copy link
Member

Description

Another small follow-up to #419 that squashed another couple of quirks in the statistics tracking.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added fix Fix for something that isn't working DD Anything related to the DD package c++ Anything related to C++ code labels Sep 13, 2023
@burgholzer burgholzer added this to the DD Package Improvements milestone Sep 13, 2023
@burgholzer burgholzer self-assigned this Sep 13, 2023
@burgholzer burgholzer enabled auto-merge (squash) September 13, 2023 19:18
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #424 (b4e80f4) into main (6df3338) will decrease coverage by 0.1%.
Report is 1 commits behind head on main.
The diff coverage is 94.1%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #424     +/-   ##
=======================================
- Coverage   89.5%   89.5%   -0.1%     
=======================================
  Files        102     102             
  Lines      11923   11925      +2     
  Branches    2098    2097      -1     
=======================================
- Hits       10680   10679      -1     
- Misses      1243    1246      +3     
Flag Coverage Δ
cpp 89.5% <94.1%> (-0.1%) ⬇️
python 100.0% <ø> (ø)
Files Changed Coverage Δ
src/dd/MemoryManager.cpp 83.0% <75.0%> (-1.7%) ⬇️
include/dd/UniqueTable.hpp 97.8% <100.0%> (ø)
src/dd/statistics/MemoryManagerStatistics.cpp 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

Signed-off-by: burgholzer <[email protected]>
@github-actions
Copy link
Contributor

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

@burgholzer burgholzer merged commit 52813cc into main Sep 14, 2023
34 checks passed
@burgholzer burgholzer deleted the statistics-fixes branch September 14, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code DD Anything related to the DD package fix Fix for something that isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant