🚸 Follow-up for DD statistics #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: burgholzer <[email protected]>
they would always equal `gc_runs` Signed-off-by: burgholzer <[email protected]>
it's a static quantity anyways Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
burgholzer
added
usability
This reverts commit c5946ac.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
=======================================
- Coverage 89.4% 89.4% -0.1%
=======================================
Files 102 102
Lines 11743 11761 +18
Branches 2080 2085 +5
=======================================
+ Hits 10509 10524 +15
- Misses 1234 1237 +3
|
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Cpp-Linter Report ✔️No problems need attention. Have any feedback or feature suggestions? Share it here. |
4 tasks
burgholzer
added a commit
that referenced
this pull request
Sep 14, 2023
## Description Another small follow-up to #419 that squashed another couple of quirks in the statistics tracking. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small follow-up PR that fixes up a few things and improves the overall statistics tracking.
Checklist: