✨ Add function to detect if non-operational status is due to wire kink #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
…_func' into add_non_operational_due_to_kinks_func
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
…_func' into add_non_operational_due_to_kinks_func
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/is_operational.hpp
Show resolved
Hide resolved
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
Signed-off-by: GitHub Actions <[email protected]>
marcelwa
previously approved these changes
Nov 24, 2024
|
@Drewniok sorry I was too fast with the approval. Once you fixed the CI, we can merge though 🙂 |
|
@marcelwa Some other changes were necessary due to some mistakes I made. It would be great if you could go through it again. Thank you very much! 🙏 |
…_func' into add_non_operational_due_to_kinks_func
marcelwa
requested changes
Nov 25, 2024
…_func' into add_non_operational_due_to_kinks_func
marcelwa
requested changes
Nov 25, 2024
marcelwa
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a function that determines if the layout is non-operational due to kinks.
Checklist: