CMG updates to Heppy #17

gpetruc · 2015-02-10T16:22:57Z

Updates to Heppy that have already been integrated from CMG side

make sure jets are consistently sorted by pT even when a new set of jet energy corrections or a smearing are applied: Heppy: Adding jet pT sorting CERN-PH-CMG/cmg-cmssw#208
fix the met without muons: Heppy - Fixed metNoMu to still subtract the muons even when not recalibr... CERN-PH-CMG/cmg-cmssw#218
fixed quark-gluon discriminator: Heppy - fixed QGLikelihood for 72X CERN-PH-CMG/cmg-cmssw#228
adding raw MET: Heppy METAnalyzer: add rawmet CERN-PH-CMG/cmg-cmssw#229
add more command line options to heppy binary: gpetruc/cmg-cmssw@3e0c575
tau POG updates: Heppy: Update tau object/analyzer/filler to latest POG recommendations CERN-PH-CMG/cmg-cmssw#241
photon isolation and id updates: Heppy - Replaced PAT photon isolation with RECO isolation CERN-PH-CMG/cmg-cmssw#234 Heppy - implemented full5x5 photon clustershape methods CERN-PH-CMG/cmg-cmssw#227
jet cleaning from photons and raw MET Cherry picked Heppy only commits related to PR 242 CERN-PH-CMG/cmg-cmssw#245 Heppy: jets and photons cleaning and met type1 with chs jets CERN-PH-CMG/cmg-cmssw#249
c++ tool for lepton isolation recalculation ( 2303f3c )
mini isolation ( 6d0eabe https://indico.cern.ch/event/368826/ )
more flexible jet-lepton cleaning: it can discard the lepton instead of the jet under if configured to do so, and saves the output of the discarded jets and leptons (cherry-picked from Lepton object updates: EGamma MVA eleId for Phys14, and MiniIsolation CERN-PH-CMG/cmg-cmssw#223 )
faster isolated track veto using the c++ class above (Heppy - faster IsoTrackAnalyzer CERN-PH-CMG/cmg-cmssw#237 rebased)
a few small updates to heppy (small speedup in some modules, better printout of NTupleVariable and similar objects, better timereport)

@arizzi @mariadalfonso

Update Heppy branch as well

Pull cms-sw#198 into Heppy branch (as it was supposed to be)

Heppy: Adding jet pT sorting

…ibrating

…QGDev/blob/master/qgMiniTuple/plugins/qgMiniTuple.cc#L321)

Heppy - Fixed metNoMu to still subtract the muons even when not recalibr...

Heppy - fixed QGLikelihood for 72X

Heppy METAnalyzer: add rawmet

…logger

…el, and add -o and getHeppyOption to allow passing command line options to cfgs for testing

Upstream Heppy updates: logger verbosity and minor fixes

Heppy - implemented full5x5 photon clustershape methods

https://github.com/mmasciov/cmg-cmssw into mmasciov-myHeppy_PhotonIso Heppy - Replaced PAT photon isolation with RECO isolation Conflicts: PhysicsTools/Heppy/python/analyzers/objects/autophobj.py (trivial)

Conflicts: PhysicsTools/HeppyCore/scripts/heppy_batch.py

…ibrating Conflicts: PhysicsTools/Heppy/python/analyzers/objects/METAnalyzer.py

…n to Imperial College Conflicts: PhysicsTools/Heppy/python/analyzers/objects/METAnalyzer.py PhysicsTools/HeppyCore/scripts/heppy_batch.py

Cherry picked Heppy only commits related to PR 242

Heppy: Update tau object/analyzer/filler to latest POG recommendations

…PR18 Heppy CMSSW Preprocessor, and performance improvement in LHEAnalyzer

…s not validated

* allow specifying an arbitrary isolation cut function (isoCut), to cover choices of radii, relative vs absolute iso, etc. * allow computation of miniIsolation, as presented in https://indico.cern.ch/event/368826/ * rearrange code to first compute all inclusive leptons, then compute loose ones. this allows e.g. vetoing inclusive leptons in isolation cones of other leptons

…o keep the lepton or the jet during cleaning, save discarded objects, and make more consistent cleaning of genJets

…include leptons to setPackedCandidates

…s_PRs_223_227_noEleMVA Port some PRs into Heppy branch

Heppy: jets and photons cleaning and met type1 with chs jets

Heppy optimizations and an improved time report

gpetruc · 2015-02-16T13:29:03Z

Hi,

Any chance of getting this merged soon?

There's more to come from our side, in addition to #19, as you can see from the cmgtools github
( https://github.com/CERN-PH-CMG/cmg-cmssw/pulls?q=is%3Apr+label%3A%22to+propagate+to+Colin%22+ ).
Should I add them here, rather than waiting for this to be done to make a new one?

Giovanni

cbernet · 2015-02-16T16:33:58Z

Hi,

You can add to this PR.

C

Le 16 févr. 2015 à 14:29, Giovanni Petrucciani [email protected] a écrit :

Hi,

Any chance of getting this merged soon?

There's more to come from our side, in addition to #19, as you can see from the cmgtools github
( https://github.com/CERN-PH-CMG/cmg-cmssw/pulls?q=is%3Apr+label%3A%22to+propagate+to+Colin%22+ ).
Should I add them here, rather than waiting for this to be done to make a new one?

Giovanni

—
Reply to this email directly or view it on GitHub.

gpetruc · 2015-02-16T16:55:35Z

Ok, I have added everything that exists now in the heppy branch in the CMGTools repository, and updated the description of the pull request to reflect this.
Note that the e/gamma MVA electron id is still left outside in #19

Hi Giovanni, Thank you very much. I'll merge faster next time.

gpetruc and others added 30 commits January 16, 2015 17:21

Merge pull request cms-sw#203 from gpetruc/heppy_7_2_2_patch2

0ceb381

Update Heppy branch as well

Merge pull request cms-sw#204 from mariadalfonso/heppyMETjetFIX

c5ae251

Pull cms-sw#198 into Heppy branch (as it was supposed to be)

Adding jet pT sorting

c847955

Merge pull request cms-sw#208 from safarzad/Heppy_fixJetPtSorting

57a7ba5

Heppy: Adding jet pT sorting

Heppy - Fixed metNoMu to still subtract the muons even when not recal…

35c4d98

…ibrating

back to using full5x5 clustershapes

510aeca

full5x5 methods now have full5x5 in the name

9e02d58

updated to new particle selection (see https://github.com/UAEDF-tomc/…

b0c6ee9

…QGDev/blob/master/qgMiniTuple/plugins/qgMiniTuple.cc#L321)

Heppy METAnalyzer: add rawmet

7098b11

compatible with new version of rootfile

a27ec8a

Replaced PAT photon isolation with RECO isolation

ee70199

Added import ROOT

f869cd7

Merge pull request cms-sw#218 from CMSRA1/heppy_7_2_2_patch2

da3ff5c

Heppy - Fixed metNoMu to still subtract the muons even when not recalibr...

Merge pull request cms-sw#228 from pandolf/QGfix

bd5fa79

Heppy - fixed QGLikelihood for 72X

Merge pull request cms-sw#229 from mariadalfonso/rawMET

4eaa19e

Heppy METAnalyzer: add rawmet

Update tau object/analyzer/filler to latest POG recommendations

ebb56d7

Merge remote-tracking branch 'cbernet/heppy_7_2_2_patch2' into heppy_…

84da9bc

…logger

HeppyCore heppy: add verbose switch to bring logging to INFO info lev…

3e0c575

…el, and add -o and getHeppyOption to allow passing command line options to cfgs for testing

Merge pull request cms-sw#238 from gpetruc/heppy_colin_20150206

71d0757

Upstream Heppy updates: logger verbosity and minor fixes

Use correct name + check for presence of decay mode finding ID in config

a0fb513

Update to latest tau POG recommendation

a8242c1

Merge pull request cms-sw#227 from pandolf/photonfix

17cd775

Heppy - implemented full5x5 photon clustershape methods

Merge pull request cms-sw#234 from mmasciov/myHeppy_PhotonIso

557e9bd

https://github.com/mmasciov/cmg-cmssw into mmasciov-myHeppy_PhotonIso Heppy - Replaced PAT photon isolation with RECO isolation Conflicts: PhysicsTools/Heppy/python/analyzers/objects/autophobj.py (trivial)

Heppy - Fixed bug with batch submission at Imperial College

2919ae5

Conflicts: PhysicsTools/HeppyCore/scripts/heppy_batch.py

Heppy - added metNoPhoton to the met analyzer

6cdbc49

Heppy - Fixed metNoMu to still subtract the muons even when not recal…

fc11499

…ibrating Conflicts: PhysicsTools/Heppy/python/analyzers/objects/METAnalyzer.py

Heppy - Fixed metNoMu to still subtract the muons even when not recal…

d14d64e

…ibrating Conflicts: PhysicsTools/Heppy/python/analyzers/objects/METAnalyzer.py

Heppy - Fixed metNoMu to still subtract the muons even when not recal…

36d52a8

…ibrating Conflicts: PhysicsTools/Heppy/python/analyzers/objects/METAnalyzer.py

Heppy - updated the METAnalyzer and added options for batch submissio…

fb96110

…n to Imperial College Conflicts: PhysicsTools/Heppy/python/analyzers/objects/METAnalyzer.py PhysicsTools/HeppyCore/scripts/heppy_batch.py

Update impact parameter handling to POG recommendations

1d5531d

gpetruc and others added 20 commits February 11, 2015 18:27

Merge pull request cms-sw#245 from CMSRA1/heppy_7_2_2_patch2

195501c

Cherry picked Heppy only commits related to PR 242

Heppy Jet: cleaning jet-photon only on with the laeading photon

eaac3d9

Heppy Jet: cleaning jet-photon only on with the laeading photon

7866c8e

Merge pull request cms-sw#241 from steggema/heppy_7_2_2_patch2_UpdateTau

909d431

Heppy: Update tau object/analyzer/filler to latest POG recommendations

Merge pull request cms-sw#250 from gpetruc/heppy_preprocessor_cbernet…

ae2a5b5

…PR18 Heppy CMSSW Preprocessor, and performance improvement in LHEAnalyzer

Heppy: tool to recompute lepton isolation in C++; weights for neutral…

2303f3c

…s not validated

Heppy JetAnalyzer: improvements in cleaning\nallow choosing whether t…

cc47e6d

…o keep the lepton or the jet during cleaning, save discarded objects, and make more consistent cleaning of genJets

now using compiled IsolationComputer

a6af4bb

added configurable fromPV() threshold and dz threshold and option to …

219be17

…include leptons to setPackedCandidates

removed useless cmgCand handle

0196c69

fixed parentheses

0fcc5e5

Merge pull request cms-sw#252 from gpetruc/heppy_leptonsAndJetsUpdate…

e75ade2

…s_PRs_223_227_noEleMVA Port some PRs into Heppy branch

add configurable first photon jet cleaning

3352fbe

Merge pull request cms-sw#249 from mariadalfonso/JETmetUpdate

8de30f1

Heppy: jets and photons cleaning and met type1 with chs jets

HeppyCore: add a line with the total in the time report

929d118

Heppy: more decent printout of NTupleVariable and such

16d1cad

Heppy: speed up a bit the GeneratorAnalyer (~10%)

aafde41

HeppyCore: Small speedup of combinatorics in MC matching

475bc9e

Merge pull request cms-sw#258 from gpetruc/heppyOptimizations

6520f24

Heppy optimizations and an improved time report

cbernet added a commit that referenced this pull request Feb 17, 2015

Merge pull request #17 from gpetruc/heppy_7_2_2_patch2

4838fdf

Hi Giovanni, Thank you very much. I'll merge faster next time.

cbernet merged commit 4838fdf into cbernet:heppy_7_2_2_patch2 Feb 17, 2015

gpetruc mentioned this pull request Feb 18, 2015

Heppy upstream bugfixes and crab cfg examples CERN-PH-CMG/cmg-cmssw#264

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CMG updates to Heppy #17

CMG updates to Heppy #17

gpetruc commented Feb 10, 2015

gpetruc commented Feb 16, 2015

cbernet commented Feb 16, 2015

gpetruc commented Feb 16, 2015

CMG updates to Heppy #17

CMG updates to Heppy #17

Conversation

gpetruc commented Feb 10, 2015

gpetruc commented Feb 16, 2015

cbernet commented Feb 16, 2015

gpetruc commented Feb 16, 2015