Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getByLabel ---> getByToken #238

Merged

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Aug 5, 2013

first patch for using getByToken [the EventTriggerFilter still needs to be updated .... ]

@ktf
Copy link
Contributor

ktf commented Aug 5, 2013

@rovere @deguio, can you check?

@ghost ghost assigned deguio Aug 5, 2013
@rovere
Copy link
Contributor

rovere commented Aug 5, 2013

Ciao Mia,
ho visto sono inclusi alcuni __init__.py files nella pull request: potresti toglierli?
@mtosi, @ktf, @deguio

@rovere
Copy link
Contributor

rovere commented Aug 6, 2013

Ciao Giulio,
una domanda veloce veloce: Mia ha cambiato al volo la sua branch locale e la pull request si e' aggiornata automaticamente, come e' giusto che sia.

non sarebbe + safe bloccare questo comportamento di default? non tutti gli utenti potrebbero essere smart enough per capire che se committano su una branch che e' ancora attiva in una pull alterano la pull stessa.....

@ktf, @deguio @mtosi

@nclopezo
Copy link
Contributor

nclopezo commented Aug 6, 2013

Hi,

I took CMSSW_7_0_X_2013-08-01-0200, pulled these changes, and ran the RelVals and unit tests, all tests passed.

@ktf
Copy link
Contributor

ktf commented Aug 6, 2013

@nclopezo Please use a recent release when testing things.

@nclopezo
Copy link
Contributor

nclopezo commented Aug 6, 2013

Hi Giulio,

I actually used CMSSW_7_0_X_2013-08-06-0200, I copy pasted the comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2013

The following categories have been signed by @rovere: DQM

@cms-git-dqm

ktf added a commit that referenced this pull request Aug 9, 2013
@ktf ktf merged commit b821ef9 into cms-sw:CMSSW_7_0_X Aug 9, 2013
jshlee referenced this pull request in gem-sw/cmssw Jun 20, 2014
…HC14

Csc trigger upgrade gem rpc for slhc14
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Feb 10, 2015
Upstream Heppy updates: logger verbosity and minor fixes
parbol pushed a commit to parbol/cmssw that referenced this pull request Mar 5, 2015
parbol pushed a commit to parbol/cmssw that referenced this pull request Mar 5, 2015
parbol pushed a commit to parbol/cmssw that referenced this pull request Mar 5, 2015
- allow choosing which loose isolation to use (ptRel recovery, miniIso)
- prefetch files if they're on Wigner (run heppy with -o nofetch to disable)
- use the getHeppyOption to select tests (as cms-sw#238)
makortel pushed a commit to makortel/cmssw that referenced this pull request Apr 22, 2015
More global git parameters.
jpata pushed a commit to jpata/cmssw that referenced this pull request Oct 26, 2015
hyunyong pushed a commit to hyunyong/cmssw that referenced this pull request Dec 12, 2016
jbsauvan added a commit to jbsauvan/cmssw that referenced this pull request Nov 7, 2018
bi-ran added a commit to bi-ran/cmssw that referenced this pull request Jul 15, 2019
silence warnings (no calo constituents)
slava77 pushed a commit to slava77/cmssw that referenced this pull request Oct 9, 2021
Benchmarking changes: drop phi1+2, change validation to MVT and check turbo and scaling settings
dabrahamyan pushed a commit to dabrahamyan/cmssw that referenced this pull request Oct 10, 2023
cmsbuild pushed a commit that referenced this pull request Mar 12, 2024
sarafiorendi pushed a commit to sarafiorendi/cmssw that referenced this pull request Mar 14, 2024
aloeliger pushed a commit to aloeliger/cmssw that referenced this pull request Apr 9, 2024
omiguelc pushed a commit to omiguelc/cmssw that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants