Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pinterest): improve readability and fix unthemed elements #1420

Merged
merged 39 commits into from
Nov 7, 2024

Conversation

K1aymore
Copy link
Contributor

@K1aymore K1aymore commented Nov 4, 2024

🔧 What does this fix? 🔧

I copied the changes from #1405 into here just in case, I wasn't aware of it when I started working.

  • Fixes Wrong colors in the Pinterest. Latte, Pink. #1378
  • Fixes 4/5 issues in Wrong colors in the Pinterest. Dark Macchiato, Teal. #1301
    • The text on the "Save" button is more readable in different accent colors
    • When hovering over the "Save" button, it dims rather than becoming red
    • When a post is saved, the text in the pop-up message is readable
    • When a post is unsaved, the text in the pop-up message is readable
  • The icons when hovering over a pin (among others) now have a dark background in dark themes
  • The dropdown of which board to save to is now more readable in dark themes
  • The "Created" and "Saved" buttons on the main profile page are themed
  • A strange box behind section previews is removed
  • The "Invite Collaborators" buttons no longer have a white border around them
  • Pin editing mode is themed nicer
  • Hover tooltips are no longer inverted (possibly my preference)
  • Search dropdown is now the correct color
  • Pin view:
    • Fixed the shadow around the pin
    • Increased shadow strength
    • Rounded corners
    • "View larger" and "Image search" buttons properly themed
    • Field for comment entry is no longer transparent

I could not reproduce #1415 but it seems like that is fixed?

What still needs to be fixed:

  • Creating new pins menu
  • Profile editing menus
  • Pin outlines when selected in organization mode and using a dark theme are hard to see

🗒 Checklist 🗒

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@github-actions github-actions bot added the pinterest Pinterest label Nov 4, 2024
@K1aymore
Copy link
Contributor Author

K1aymore commented Nov 4, 2024

Some before and afters:

Before (random unsaved pin):
image
After:
image

Before (main profile page):
image
After:
image

Before (editing a pin):
image
After:
image

Before (the issue from #1378):
image
After:
image

Before (issue from #1301):
image
After:
image

Before (pin view):
image
After:
image

Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR and fixing all those issues :)
Just some small issues with our guidelines.

styles/pinterest/catppuccin.user.css Outdated Show resolved Hide resolved
styles/pinterest/catppuccin.user.css Outdated Show resolved Hide resolved
@isabelroses isabelroses merged commit 7eaace7 into catppuccin:main Nov 7, 2024
3 checks passed
@isabelroses
Copy link
Member

Thanks for the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinterest Pinterest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong colors in the Pinterest. Latte, Pink.
3 participants