-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pinterest): unthemed elements #1405
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
Please be more descriptive in the description of what this changes. Provide links to where these unthemed elements were/are, or otherwise how to get to them. Screenshots, ideally before and afters, help immensely. Thanks! |
My apologies. Isabel and I both commented at the same time due to a miscommunication and I deleted the third mention of it. It's not a big deal, and I appreciate your contributions :)
When you aren't the maintainer, yes. Reviewers need to know what is being changed. If you want to take on this userstyle and maintain it going forward, we can be a little more forgiving. |
I would have to agree with this statement, but even more so for very broken themes like Pinterest where half my loading page is broken, see image below. |
superseded by #1420 |
@isabelroses I made a PR. You approved it but didn't merge. Someone took my contribution and built on it in another PR. You close mine and merge theirs? Weird. |
Yes, I'm sorry about that, I expected for uncenter to review but they didn't, and seeing as they haven't been so active this week I went ahead and merged the other PR. But your right, I should have merged your PR first and asked them to rebase. I'm sorry. |
oh it's okay then |
🔧 What does this fix? 🔧
some unthemed elements and broken stuff
🗒 Checklist 🗒
==UserStyle==
header of thecatppuccin.user.css
file.