Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pinterest): unthemed elements #1405

Closed
wants to merge 7 commits into from
Closed

Conversation

thismoon
Copy link
Contributor

🔧 What does this fix? 🔧

some unthemed elements and broken stuff

🗒 Checklist 🗒

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@github-actions github-actions bot added the pinterest Pinterest label Oct 27, 2024
@uncenter uncenter changed the title fix(pinterest) unthemed elements fix(pinterest): unthemed elements Oct 27, 2024
@isabelroses

This comment was marked as duplicate.

@uncenter
Copy link
Member

Please be more descriptive in the description of what this changes. Provide links to where these unthemed elements were/are, or otherwise how to get to them. Screenshots, ideally before and afters, help immensely. Thanks!

@catppuccin catppuccin deleted a comment from comfysage Oct 27, 2024
@thismoon
Copy link
Contributor Author

Sure, I will provide screenshots of what changed
Also i got what i am supposed to do from the first comment :/

"more" button

the one with three dots next to any pin
before
image
after
image

focused search bar border

before
image
after
image

avatar placeholder background

tricky to take a screenshot of, the background of the circle placeholder that appears before any avatar/pfp loads

fix pin external link and its sequel

fixes existing theming of that bubble that appears on some pins that have an external links
before
image
after
image

border focus

before
image
after
image

also am i expected to take screenshots every time? it takes time and overcomplicates the process

@uncenter
Copy link
Member

Also i got what i am supposed to do from the first comment :/

My apologies. Isabel and I both commented at the same time due to a miscommunication and I deleted the third mention of it. It's not a big deal, and I appreciate your contributions :)

also am i expected to take screenshots every time? it takes time and overcomplicates the process

When you aren't the maintainer, yes. Reviewers need to know what is being changed. If you want to take on this userstyle and maintain it going forward, we can be a little more forgiving.

@isabelroses
Copy link
Member

also am i expected to take screenshots every time? it takes time and overcomplicates the process

When you aren't the maintainer, yes. Reviewers need to know what is being changed. If you want to take on this userstyle and maintain it going forward, we can be a little more forgiving.

I would have to agree with this statement, but even more so for very broken themes like Pinterest where half my loading page is broken, see image below.

{8B754B10-941C-40CD-AD0A-DF226DD382FC}

@isabelroses
Copy link
Member

superseded by #1420

@isabelroses isabelroses closed this Nov 8, 2024
@thismoon
Copy link
Contributor Author

thismoon commented Nov 9, 2024

@isabelroses I made a PR. You approved it but didn't merge. Someone took my contribution and built on it in another PR. You close mine and merge theirs? Weird.

@isabelroses
Copy link
Member

@isabelroses I made a PR. You approved it but didn't merge. Someone took my contribution and built on it in another PR. You close mine and merge theirs? Weird.

Yes, I'm sorry about that, I expected for uncenter to review but they didn't, and seeing as they haven't been so active this week I went ahead and merged the other PR. But your right, I should have merged your PR first and asked them to rebase. I'm sorry.

@thismoon
Copy link
Contributor Author

thismoon commented Nov 9, 2024

oh it's okay then

@thismoon thismoon deleted the pinterest branch November 9, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinterest Pinterest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants