Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(QTM-713): Input component migrated to CSS modules #589

Merged
merged 26 commits into from
Oct 4, 2024

Conversation

MarcosViniciusPC
Copy link
Contributor

@MarcosViniciusPC MarcosViniciusPC commented Oct 4, 2024

Description

https://jirasoftware.catho.com.br/browse/QTM-713

Review guide

  • Unit tests (yarn test:components)
  • Regression
    - first start the storybook for regression tests(and keep it open): yarn test:regression:storybook;
    - then run the regression tests: yarn test:regression
  • Code review
  • Build
  • TypeScript updated

How to test build

How to test visual changes

Note:

  • It is important to check states (hover, focus, disabled, etc.), as they are not valid for regressive tests (yarn test:regression)
  • Changes that are not related to the objective of the task are related to the merge made from the master branch. The intention here is to keep all features from the master branch in the beta branch

LucasFlaquer and others added 24 commits September 12, 2024 14:42
Update TabView Component to change tab when activeTab changes
feat(Icon.jsx): Added icons outside the MUI, updating unit tests and …
feat(QTM-779): Add close functionality when clicks on elements other than the popover
feat(QTM-786): Added "button" type to prevent form submission when opening options list
@MarcosViniciusPC MarcosViniciusPC added status:ready to review and removed issue:wip Someone is solving this problem labels Oct 4, 2024
Copy link

sonarqubecloud bot commented Oct 4, 2024

@MarcosViniciusPC MarcosViniciusPC merged commit 81e7ae0 into beta Oct 4, 2024
3 checks passed
@MarcosViniciusPC MarcosViniciusPC deleted the QTM-713 branch October 4, 2024 13:48
Copy link

github-actions bot commented Oct 4, 2024

🎉 This PR is included in version 10.0.0-beta.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants