-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TabView Component to change tab when activeTab changes #585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[x] Code review
Very good, thank you for your contribution.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[x] Code review
[x] Unit
[x] Regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Unit
- Regression
🎉 This PR is included in version 10.0.0-beta.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
related to: #584
<TabView />
so could be able to change the current tab from another component. Example above:(this example was taken from
recruiter-onboarding_recruiter-account_app/src/components/TabView/index.tsx
)Setup
to view the components behavior, run
yarn storybook
Review guide
-
yarn test:coverage
- first start the storybook for regression tests(and keep it open):
yarn test:regression:storybook
;- then run the regression tests:
yarn test:regression
A11y review
Browsers review