Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TabView Component to change tab when activeTab changes #585

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

LucasFlaquer
Copy link
Contributor

@LucasFlaquer LucasFlaquer commented Sep 12, 2024

Description

related to: #584

  • Transformation of the component from class component into functional component
  • Enhancement of the component <TabView /> so could be able to change the current tab from another component. Example above:
    image
    (this example was taken from recruiter-onboarding_recruiter-account_app/src/components/TabView/index.tsx)

Setup

to view the components behavior, run yarn storybook

Review guide

  • Coverage (coverage status should not regress)
    - yarn test:coverage
  • Unit tests (yarn test:components)
  • Regression
    - first start the storybook for regression tests(and keep it open): yarn test:regression:storybook;
    - then run the regression tests: yarn test:regression
  • Code review
  • TypeScript updated

A11y review

  • A11y checks
    • accessible via keyboard?
    • Identifiable through assistive technology (screen-reader chrome extension)?
    • Semantically correct html elements (or if necessary identified by WAI-ARIA)?
    • Is there a deficiency in color contrast?

Browsers review

  • Layout review
    • Edge
    • Firefox
    • Chrome
    • Safari
    • Mobile
  • Ux review validation

@LucasFlaquer LucasFlaquer marked this pull request as ready for review September 12, 2024 18:09
Copy link
Contributor

@MarcosViniciusPC MarcosViniciusPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[x] Code review

Very good, thank you for your contribution.

components/TabbedView/TabbedView.jsx Outdated Show resolved Hide resolved
Copy link

Copy link
Contributor

@MarcosViniciusPC MarcosViniciusPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[x] Code review
[x] Unit
[x] Regression

@alizeleal alizeleal added status:reviewing Someone is reviewing this PR and removed status:pending review labels Sep 16, 2024
Copy link
Contributor

@alizeleal alizeleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Unit
  • Regression

@alizeleal alizeleal added status:approved and removed status:reviewing Someone is reviewing this PR labels Sep 16, 2024
@MarcosViniciusPC MarcosViniciusPC merged commit e248366 into master Sep 16, 2024
3 checks passed
@MarcosViniciusPC MarcosViniciusPC deleted the tab-view-fix branch September 16, 2024 20:01
@MarcosViniciusPC MarcosViniciusPC restored the tab-view-fix branch September 16, 2024 20:03
Copy link

github-actions bot commented Oct 4, 2024

🎉 This PR is included in version 10.0.0-beta.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MarcosViniciusPC MarcosViniciusPC mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants