Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/offer creation validations #193

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -646,13 +646,21 @@ Description
<br>
<br>

###### #2 Submit App for Marketrelease
###### #2 Submit App for Marketplace Release
Description

```diff
! PUT /api/apps/appreleaseprocess/{appId}/submit
```

Validations:

* validates document upload (lead image, app image, confirmity document)
* validates the signed agreements
* validates if roles are uploaded
* validates if technical user profile is configured
* validates if privacy policy is set

<br>
<br>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,21 @@ With the rejection the app manager will receive an notification as well as an em
! PUT /api/apps/{appId}/declineApp
```


Details of the api logic/business logic

* update app status from "IN REVIEW" to "CREATED"
* sets document status of offer assigned documents back to "PENDING"
* App Manager of the company will receive the notification (means, with the rejection of the app release, a notification for all the company related users with the role "App Manager" of the offer "Portal" will get created)
* Notification type: "SERVICE_RELEASE_REJECTION" (new notification type)
* Notification topic "OFFER"
* Notification content
* "ServiceName":"{add here the ServiceName from offer.name}",
* "OfferId":"{add here the ServiceName from offer.id}"
* "Message":"{decline reason}"
* On top of the notification, the rejection details are send via email


<br>

Details regarding the notification can get found in the notification service documentation: Notification Service
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,13 @@ Hints:
* Sales Manager: uuid company user with role sales manager
* LanguageCode: two digit language short code (e.g. en, de, jp, pt, etc.)
* Service Type Ids: service type label (currently available: DATASPACHE_SERVICE & CONSULTING_SERVICE)


<br>

Validations:
* title is mandatory (minimum 3 characters)
* Service Type ID is mandatory

<br>
<br>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,15 @@ Request body:
Details of the api logic/business logic

* update status from "IN REVIEW" to "CREATED"
* create a notification for the service provider about the decline details
* sets document status of offer assigned documents back to "PENDING"
* Service Manager of the company will receive the notification (means, with the rejection of the service release, a notification for all the company related users with the role "Service Manager" of the offer "Portal" will get created)
* Notification type: "SERVICE_RELEASE_REJECTION" (new notification type)
* Notification topic "OFFER"
* Notification content
* "ServiceName":"{add here the ServiceName from offer.name}",
* "OfferId":"{add here the ServiceName from offer.id}"
* "Message":"{decline reason}"
* On top of the notification, the rejection details should also get send via email
* Notification type: "SERVICE_RELEASE_REJECTION" (new notification type)
* Notification topic "OFFER"
* Notification content
* "ServiceName":"{add here the ServiceName from offer.name}",
* "OfferId":"{add here the ServiceName from offer.id}"
* "Message":"{decline reason}"
* On top of the notification, the rejection details should also get send via email

<br>
<br>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,46 @@ image
<br>
<br>

### #1 Decline Service Release
The decline service release function is used to reject services and sending the them back to the status "CREATED" .
### Decline Service Release

With the rejection the service manager will receive an notification as well as an email regarding the rejection and rejection details via a message field.
```diff
! PUT /api/service/{serviceId}/declineService
```

<br>
Please note, a notification will get created and is documented in the notification service documentation: Notification Service

```diff
! PUT: /api/services/servicerelease/{serviceId}/decline
```
<br>

Request body:
<br>

{
"message": "string"
}

<br>
<br>

Details regarding the notification can get found in the notification service documentation: Notification Service
Details of the api logic/business logic

* update status from "IN REVIEW" to "CREATED"
* sets document status of offer assigned documents back to "PENDING"
* create a notification for the service provider about the decline details
* Service Manager of the company will receive the notification (means, with the rejection of the service release, a notification for all the company related users with the role "Service Manager" of the offer "Portal" will get created)
* Notification type: "SERVICE_RELEASE_REJECTION" (new notification type)
* Notification topic "OFFER"
* Notification content
* "ServiceName":"{add here the ServiceName from offer.name}",
* "OfferId":"{add here the ServiceName from offer.id}"
* "Message":"{decline reason}"
* On top of the notification, the rejection details should also get send via email

<br>
<br>

##### Email Example

image to be added