Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/offer creation validations #193

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jjeroch
Copy link

@jjeroch jjeroch commented Jun 18, 2023

Description

Please include a summary of the change.

Why

Please include an explanation of why this change is necessary as well as relevant motivation and context. List any dependencies that are required for this change.

Issue

Link to Github issue.

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@jjeroch jjeroch marked this pull request as draft June 18, 2023 20:44
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jjeroch
Copy link
Author

jjeroch commented Jun 18, 2023

will get squashed and transferred to eclipse as soon as the changes are all incorporated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant