Fix/199 fix policy api #839

dsmf · 2024-03-28T03:52:03Z

contains:

fixes
create policy request returns policy id now
business logic was moved from controller to service (separation of concerns: test of business logic in service only, controller test only web layer stuff)
harmonized with Extend the structure of how the IRS can handle Policies eclipse-tractusx/item-relationship-service#249
consistent naming for business partner number parameters
added tests
structured tests with Nested (helps that relevant test cases do not get forgotten, tests easier to find)
should already contain implementation for Register policy definition for BPNL should accept only valid BPNLs eclipse-tractusx/item-relationship-service#505 (because we needed some validation anyway to avoid consequential errors)
irs-api.yaml updated
default handling clarified and corrected

…ors)

…ting

By moving business logic from PolicyStoreController to PolicyStoreService the PolicyStoreServiceTest can test all business logic while the PolicyStoreControllerTest can focus on web layer concerns such as parameter validation. Besides this, tests were structured via Nested in order to group tests for each method together. This helps not to forget about test cases.

github-actions · 2024-03-28T03:52:29Z

CHANGELOG file was not updated! Make sure to include important changes.

…ion for GET policies

irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/AbstractDelegate.java

…delegate/AbstractDelegate.java

...api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/RelationshipDelegate.java

…delegate/RelationshipDelegate.java

irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/SubmodelDelegate.java

…delegate/SubmodelDelegate.java

irs-api/src/main/java/org/eclipse/tractusx/irs/aaswrapper/job/delegate/SubmodelDelegate.java

…delegate/SubmodelDelegate.java

irs-api/src/main/java/org/eclipse/tractusx/irs/services/validation/JsonValidatorService.java

…tion/JsonValidatorService.java

irs-api/src/main/java/org/eclipse/tractusx/irs/services/validation/JsonValidatorService.java

…tion/JsonValidatorService.java

irs-api/src/main/java/org/eclipse/tractusx/irs/services/validation/JsonValidatorService.java

…tion/JsonValidatorService.java

irs-api/src/main/java/org/eclipse/tractusx/irs/services/validation/JsonValidatorService.java

…tion/JsonValidatorService.java

irs-api/src/main/java/org/eclipse/tractusx/irs/util/JsonUtil.java

...icy-store/src/main/java/org/eclipse/tractusx/irs/policystore/models/CreatePolicyRequest.java

…store/models/CreatePolicyRequest.java

ds-jhartmann

LGTM

…/199-fix-policy-api

sonarqubecloud · 2024-04-10T08:30:19Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dsmf added 23 commits March 25, 2024 19:49

fix(impl): [#199] fixes for incorrect implementation

cd665dd

fix(impl): [#199] Add 500er to OpenApiExamples.java

b697f63

fix(impl): [#199] Add CreatePoliciesResponse

c7bd17d

fix(impl): [#199] Correct CreatePolicyRequest OpenAPI

6c7fd6f

fix(impl): [#199] Add BPN regex constant

f17feda

fix(impl): [#199] Fix OpenAPI

df32eb2

fix(impl): [#199] Update insomnia collection for POST policy

00dfa3c

fix(impl): [#199] Improve variable naming

7e07b49

fix(impl): [#199] Add BPN validator

4a20918

fix(impl): [#199] Fix api doc

5dee36a

fix(impl): [#199] Fix UpdatePolicyRequest attribute naming

d500025

fix(impl): [#199] Fix UpdatePolicyRequest (attribute name and validat…

fba5c64

…ors)

fix(impl): [#199] PolicyPersistence: return saved policy

bb09996

fix(impl): [#199] Correct updateAllowedPolicy API doc and code format…

01bda79

…ting

fix(impl): [#199] Rename request parameter for GET policies

2be0088

fix(impl): [#199] Code formatting

968b04d

fix(impl): [#199] Remove relicts from move of business logic to service

97122e8

fix(impl): [#199] Add additional validation to avoid wrong API usage

8397352

fix(impl): [#199] Correct IRS collection for PUT policies request

a87a67a

fix(impl): [#199] Fix gitignore

6a75e29

fix(impl): [#199] Fix validation and add documentation

21b107c

fix(impl): [#199] tests

e2ba964

dsmf mentioned this pull request Mar 28, 2024

Register policy definition for certain BPNLs eclipse-tractusx/item-relationship-service#199

Closed

6 tasks

dsmf added 5 commits March 28, 2024 04:59

fix(impl): [#199] Correct API doc

09925a4

fix(impl): [#199] Format code

f9400dc

fix(impl): [#199] Fix checkstyle

6e3b488

fix(impl): [#199] Fix OpenAPI annotation

b86b209

fix(impl): [#199] add todo concerning OpenAPI response value descript…

78c4246

…ion for GET policies

dsmf marked this pull request as ready for review April 10, 2024 01:12