Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/439 change impl accepted aspect #807

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Feature/439 change impl accepted aspect #807

merged 9 commits into from
Mar 12, 2024

Conversation

ds-ext-kmassalski
Copy link

@ds-ext-kmassalski ds-ext-kmassalski commented Mar 7, 2024 •
edited by dsmf
Loading

@dsmf dsmf self-requested a review March 7, 2024 18:19
dsmf
dsmf suggested changes Mar 7, 2024
View reviewed changes
Copy link

@dsmf dsmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality Gate failed -> Coverage

@dsmf dsmf assigned ds-ext-kmassalski and unassigned dsmf Mar 7, 2024
@dsmf dsmf mentioned this pull request Mar 7, 2024
Closed
9 tasks
ds-jhartmann
ds-jhartmann reviewed Mar 11, 2024
View reviewed changes
Copy link

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there are some Sonar Issues. Please fix them

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
28.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@ds-ext-kmassalski
Copy link
Author

Sonar fixed

ds-jhartmann
ds-jhartmann approved these changes Mar 12, 2024
View reviewed changes
Copy link

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsmf
dsmf approved these changes Mar 12, 2024
View reviewed changes
Copy link

@dsmf dsmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just see the my comment please for clarification

docs/src/api/irs-api.yaml Show resolved Hide resolved
@ds-ext-kmassalski ds-ext-kmassalski merged commit d79aa1e into main Mar 12, 2024
@ds-ext-kmassalski ds-ext-kmassalski deleted the feature/439-change-impl-accepted-aspect branch March 12, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds-jhartmann ds-jhartmann ds-jhartmann approved these changes

@dsmf dsmf dsmf approved these changes

Assignees

@ds-jhartmann ds-jhartmann

@ds-ext-kmassalski ds-ext-kmassalski

@ds-psosnowski ds-psosnowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ds-ext-kmassalski @dsmf @ds-jhartmann @ds-psosnowski