Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recursion): Fix BPN handling in delegates #439

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

ds-jkreutzfeld
Copy link

The BPN is now correctly taken from the submodels and passed down the recursive chain instead of always taken from the JobParameter. If no BPN is available, a Tombstone is created now as well.

The BPN is now correctly taken from the submodels and passed down the recursive chain instead of always taken from the JobParameter.
If no BPN is available, a Tombstone is created now as well.
Copy link

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Code coverage is not met but apart from the newly introduced tombstones for a missing BPN I don't think this matters.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.7% 91.7% Coverage
0.0% 0.0% Duplication

@ds-jkreutzfeld ds-jkreutzfeld merged commit 12b1ad1 into main Jul 20, 2023
@ds-jkreutzfeld ds-jkreutzfeld deleted the fix/add-correct-bpn-handling branch July 20, 2023 08:55
ds-ext-kmassalski added a commit that referenced this pull request Mar 7, 2024
ds-ext-kmassalski added a commit that referenced this pull request Mar 7, 2024
ds-ext-kmassalski added a commit that referenced this pull request Mar 11, 2024
…on-update

feat(impl):[#439] insomnia collection update
ds-ext-kmassalski added a commit that referenced this pull request Mar 12, 2024
ds-ext-kmassalski added a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants