Re: fixing missing std:: (see #559) #559
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original #544 got prematurely closed, appears this is the only way to reopen.
The main criticism of this pull request:
This is due to there being two std::tolower functions:
A cast is necessary to tell the compiler to disambiguate which function pointer we are taking.
I propose this change be taken at this time as it resolves the compatibility issues but a new issue should be raised to discuss the best solution as whether to keep, or change to use a function object that calls the std::tolower internally or other viable alternatives.