Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re: fixing missing std:: (see #559) #559

Closed
wants to merge 11 commits into from
Closed

Re: fixing missing std:: (see #559) #559

wants to merge 11 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 17, 2015

The original #544 got prematurely closed, appears this is the only way to reopen.

The main criticism of this pull request:

static_cast<int(*)(int)>(std::tolower)

This is due to there being two std::tolower functions:

 std::tolower(int)
charT tolower( charT ch, const locale& loc );

A cast is necessary to tell the compiler to disambiguate which function pointer we are taking.

I propose this change be taken at this time as it resolves the compatibility issues but a new issue should be raised to discuss the best solution as whether to keep, or change to use a function object that calls the std::tolower internally or other viable alternatives.

@nabijaczleweli
Copy link
Contributor

Instead of a function object, you can just have a free catch::tolower() function

@ghost ghost mentioned this pull request Dec 21, 2015
@ghost ghost changed the title Re: fixing missing std:: (see #544) Re: fixing missing std:: (see #559) Dec 21, 2015
@horenmar
Copy link
Member

I reimplemented this, because Clara is an external dependency for Catch and should not be changed here + the history was a mess.

@horenmar horenmar closed this Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants