Added std:: where it was missing #544
Conversation
|
👍 |
|
Okay, so currently Travis doesn't like it if I changed ::tolower to std::tolower. Some other fix is evidently necessary to fix that issue. In my gcc 4.4.2 compiler I am getting: |
|
Is there a |
|
Good call @kirbyfan64 will add the missing include into clara.h and catch_common.hpp and put the std:: back in : Q) Is there an easy way to roll back changes on github? I just re-made the changes instead for now! |
|
@crog You can use the standard set of git commands |
|
Thanks, I will take a look at Git commands soon. For now I can't solve the issue of ::tolower as Travis build system doesn't have a test that replicates a strict conforming environment like I have here :( |
|
Cracked it. GCC reports nicely in some versions about std::tolower having ambiguous overloads. Fixing the ambiguity with the following tells the compiler which function to use and this now builds under QNX and all the Travis Test :) |
|
👍 |
| @@ -232,7 +233,7 @@ namespace Clara { | |||
| } | |||
| inline void convertInto( std::string const& _source, bool& _dest ) { | |||
| std::string sourceLC = _source; | |||
| std::transform( sourceLC.begin(), sourceLC.end(), sourceLC.begin(), ::tolower ); | |||
| std::transform( sourceLC.begin(), sourceLC.end(), sourceLC.begin(), static_cast<int(*)(int)>(std::tolower) ); | |||
There was a problem hiding this comment.
this doesn't look good to me...
|
Apologies for the premature closure - I deleted the branch and it auto-closed all associated PRs - it wasn't intentional. |
ghost
mentioned this pull request
|
I have opened this request again under #559 |
This is in relation to issue #543 and covers the main places where std:: is missing but there may still be further calls.