Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Deployment I]: Main dockerfile #383
[Cloud Deployment I]: Main dockerfile #383
Changes from 18 commits
1ee0231
ee8873b
a0871e1
9c148a0
91bbd36
66a0aff
7de44dc
dee4842
17031c9
de6b5f6
a55749e
37862f2
45fe266
c8d6edd
c3940b7
c3984d3
dd0f2a2
fcea20a
c406e76
3488379
c08ed01
e7b5557
23285ed
9a02034
73ffcba
e0c6046
5419ce1
05944f5
a09904f
744cb56
dd481a0
e8ed3ea
8330621
73a7e16
2479d05
675abcf
323e17f
5dd6ffa
0d92791
b932329
99e673b
64f4fee
11ac0bb
729cc81
da3bd58
3729115
055f226
51e74f1
18d518f
778ede9
2b97324
1b4ad26
f2ca5fb
663ee2e
9bc34b5
3fe08b1
56bba2e
db81628
09a3ccf
7d2322b
65634d7
67b7ad5
586828a
da7835b
af9e86f
b76a18e
8cb41c7
153f95c
edc6e19
1ad92c4
5e967fa
714aa4b
2a0896d
019cf5c
62d0b49
ab82d22
25f080f
d07d750
e5a6e63
33b7b4c
22434b6
eab9ab2
ff95795
088026a
2bf30e3
47967b9
d590878
b3423e8
8ccace1
60bf1d5
5589e2f
32c18f8
7f4f5d1
1a3771d
7601724
f3dee1b
8278e57
3bc6b30
03e5fff
f20acba
58990b7
2423f28
339ee36
b18465d
843049d
f50ffab
bce202d
8172be5
e4666d0
61ccba5
a7a91a1
36d52f4
008d448
45aafee
0aa5d28
38206fc
abc7a24
9ce262a
a6ab697
29cbcc5
87704f3
36ce2c0
0e246b8
8f5bdbc
1669604
d7858bd
d4ddb67
87e5373
c29264e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also had an error after running
So I changed this to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of a CMD is to define the prepend to the entrypoint - since we want this docker image, when run as a container, to effectively emulate an entire functioning Python environment, I'm trying to design it in such a way that it is pretty much just like calling the CLI from a normal Python environment
That is, in a typical Python NeuroConv environment you would do
now with the docker we want
While it is conceptually possible to just rely on implicit entrypoint definition from successful installation and association inside the docker container, it is much safer apparently to call
python -m
directly on the moduleThis simply verifies that the module is importable, it does not route the CLI - I don't even think it would facilitate prepending of a command sent to the container either
Anyway, I think the problem was
python
vs.python3
usage. This seems to be working now, and I added a full demo if you want to check that out and see if that works for youThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, seems fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CodyCBakerPhD, and sorry this has taken be so long to review. This looks great, but as you note in the comment, I think this needs testing. Could you at least create or point to a YAML file that can be used as input for this docker run command?