Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Deployment I]: Main dockerfile #383

Merged
merged 129 commits into from
Apr 8, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Member

@CodyCBakerPhD CodyCBakerPhD commented Mar 27, 2023

TODO

  • add a test of the docker invocation that ensures the testing suite runs completely using only the docker container
  • contemplate a GitHub Action for automatically building the containers over a matrix of architectures, python versions, and even release versions

@CodyCBakerPhD CodyCBakerPhD self-assigned this Mar 27, 2023
@CodyCBakerPhD CodyCBakerPhD changed the title Main dockerfile [WIP]: Main dockerfile Apr 12, 2023
@CodyCBakerPhD CodyCBakerPhD changed the title [WIP]: Main dockerfile [Cloud Deployment - WIP]: Main dockerfile Apr 24, 2023
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review March 22, 2024 19:52
@CodyCBakerPhD
Copy link
Member Author

CodyCBakerPhD commented Mar 22, 2024

OK this is finally ready for full review @weiglszonja

@CodyCBakerPhD CodyCBakerPhD changed the title [WIP - Cloud Deployment I]: Main dockerfile [Cloud Deployment I]: Main dockerfile Mar 25, 2024
Copy link
Contributor

@weiglszonja weiglszonja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CodyCBakerPhD, looks good to me!

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) April 8, 2024 14:57
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (468157b) to head (87e5373).

❗ Current head 87e5373 differs from pull request most recent head c29264e. Consider uploading reports for the commit c29264e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
- Coverage   91.38%   91.23%   -0.15%     
==========================================
  Files         121      121              
  Lines        6300     6309       +9     
==========================================
- Hits         5757     5756       -1     
- Misses        543      553      +10     
Flag Coverage Δ
unittests 91.23% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD merged commit 70d6ce0 into main Apr 8, 2024
43 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the add_first_dockerfile branch April 8, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants