Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid doing link check on draft #1093

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

h-mayorquin
Copy link
Collaborator

As in the title. Related to #1082 and #1078

@h-mayorquin h-mayorquin added the CI label Sep 17, 2024
@h-mayorquin h-mayorquin self-assigned this Sep 17, 2024
@h-mayorquin
Copy link
Collaborator Author

The test successfully skipped on draft:

image

@h-mayorquin h-mayorquin marked this pull request as ready for review September 17, 2024 23:48
@h-mayorquin
Copy link
Collaborator Author

h-mayorquin commented Sep 18, 2024

I also noticed that this workflow does not have concurrency cancellation so I added it.

Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pauladkisson pauladkisson merged commit 4c3edc9 into main Sep 18, 2024
43 checks passed
@pauladkisson pauladkisson deleted the make_the_link_tests_not_run_on_draft branch September 18, 2024 17:03
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.44%. Comparing base (36464df) to head (1fcf2a0).
Report is 48 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1093   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files         129      129           
  Lines        8055     8050    -5     
=======================================
- Hits         7285     7281    -4     
+ Misses        770      769    -1     
Flag Coverage Δ
unittests 90.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants