Skip to content

Commit

Permalink
Avoid doing link check on draft (#1093)
Browse files Browse the repository at this point in the history
  • Loading branch information
h-mayorquin authored Sep 18, 2024
1 parent fddd4d2 commit 4c3edc9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/test-external-links.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,19 @@
name: Testing External Links
on:
pull_request:
types: [synchronize, opened, reopened, ready_for_review]
# Synchronize, open and reopened are the default types for pull request
# We add ready_for_review to trigger the check for changelog and full tests when ready for review is clicked
merge_group:
workflow_call:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
build-and-test:
if: ${{ github.event.pull_request.draft == false }}
name: Testing External Links
runs-on: ubuntu-latest
strategy:
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@

## Improvements
* Run only the most basic testing while a PR is on draft [PR #1082](https://github.com/catalystneuro/neuroconv/pull/1082)
* Avoid running link test when the PR is on draft [PR #1093](https://github.com/catalystneuro/neuroconv/pull/1093)


# v0.6.4 (September 17, 2024)

Expand Down

0 comments on commit 4c3edc9

Please sign in to comment.