-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pydantic III] Use list/dict annotations #1021
Conversation
# Conflicts: # docs/user_guide/adding_trials.rst # docs/user_guide/datainterfaces.rst
for more information, see https://pre-commit.ci
This will have conflicts with #1017. |
@h-mayorquin I was planning on doing a PR just like this after #1017 to avoid exactly that |
yeah, it may have been a bit early. Let's close this and wait |
The damage isn't too awful |
I'm unable to officially review since I opened this PR, but this looks good to me. I'm happy to merge once the tests pass |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
+ Coverage 91.37% 91.39% +0.02%
==========================================
Files 129 129
Lines 7860 7879 +19
==========================================
+ Hits 7182 7201 +19
Misses 678 678
Flags with carried forward coverage won't be shown. Click here to find out more.
|
As of Python 3.9, standard collections (list, tuple, dict) can be used in typehints instead of List, Tuple, and Dict.