-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pydantic II] Change all paths to pydantic types #1017
Conversation
for more information, see https://pre-commit.ci
…euro/neuroconv into refactor_get_signature
…uroconv into pydantic_source
…uroconv into pydantic_source
Co-authored-by: Ben Dichter <[email protected]>
…euro/neuroconv into refactor_get_signature
@h-mayorquin All tests should be green now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated but I would like to eliminate the OptionalArray as well
|
||
import numpy as np | ||
|
||
FilePathType = TypeVar("FilePathType", str, Path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's OK.
One step at a time I say 😉 |
But yes, happy to do that in follow-up |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
+ Coverage 91.37% 91.40% +0.02%
==========================================
Files 129 129
Lines 7860 7886 +26
==========================================
+ Hits 7182 7208 +26
Misses 678 678
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@h-mayorquin The follow-up replacing all usage with the Pydantic ones
Still need to make my way through the ecephys ones