Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pydantic II] Change all paths to pydantic types #1017

Merged
merged 52 commits into from
Aug 21, 2024
Merged

Conversation

CodyCBakerPhD
Copy link
Member

@h-mayorquin The follow-up replacing all usage with the Pydantic ones

Still need to make my way through the ecephys ones

@CodyCBakerPhD CodyCBakerPhD self-assigned this Aug 19, 2024
@CodyCBakerPhD CodyCBakerPhD changed the title Change all interfaces to pydantic types [Pydantic II] Change all interfaces to pydantic types Aug 19, 2024
Base automatically changed from refactor_get_signature to main August 20, 2024 17:10
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 21, 2024 14:35
@CodyCBakerPhD
Copy link
Member Author

@h-mayorquin All tests should be green now

Copy link
Collaborator

@h-mayorquin h-mayorquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but I would like to eliminate the OptionalArray as well


import numpy as np

FilePathType = TypeVar("FilePathType", str, Path)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's OK.

@h-mayorquin h-mayorquin enabled auto-merge (squash) August 21, 2024 17:21
@CodyCBakerPhD
Copy link
Member Author

Unrelated but I would like to eliminate the OptionalArray as well

One step at a time I say 😉

@CodyCBakerPhD
Copy link
Member Author

But yes, happy to do that in follow-up

@CodyCBakerPhD CodyCBakerPhD changed the title [Pydantic II] Change all interfaces to pydantic types [Pydantic II] Change all interface paths to pydantic types Aug 21, 2024
@CodyCBakerPhD CodyCBakerPhD changed the title [Pydantic II] Change all interface paths to pydantic types [Pydantic II] Change all paths to pydantic types Aug 21, 2024
@h-mayorquin h-mayorquin merged commit beb48d9 into main Aug 21, 2024
35 checks passed
@h-mayorquin h-mayorquin deleted the pydantic_source branch August 21, 2024 18:17
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 99.33775% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.40%. Comparing base (60ca62f) to head (cd6e4d2).
Report is 87 commits behind head on main.

Files with missing lines Patch % Lines
src/neuroconv/tools/data_transfers/_dandi.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
+ Coverage   91.37%   91.40%   +0.02%     
==========================================
  Files         129      129              
  Lines        7860     7886      +26     
==========================================
+ Hits         7182     7208      +26     
  Misses        678      678              
Flag Coverage Δ
unittests 91.40% <99.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/neuroconv/basedatainterface.py 94.44% <100.00%> (+0.07%) ⬆️
...nv/datainterfaces/behavior/audio/audiointerface.py 89.02% <100.00%> (+0.13%) ⬆️
...v/datainterfaces/behavior/deeplabcut/_dlc_utils.py 56.49% <100.00%> (ø)
...ces/behavior/deeplabcut/deeplabcutdatainterface.py 92.50% <100.00%> (ø)
...nterfaces/behavior/fictrac/fictracdatainterface.py 91.72% <100.00%> (+0.05%) ⬆️
...s/behavior/lightningpose/lightningposeconverter.py 96.77% <100.00%> (+0.05%) ⬆️
...havior/lightningpose/lightningposedatainterface.py 95.28% <100.00%> (+0.04%) ⬆️
...onv/datainterfaces/behavior/medpc/medpc_helpers.py 100.00% <100.00%> (ø)
...atainterfaces/behavior/medpc/medpcdatainterface.py 94.25% <100.00%> (+0.06%) ⬆️
...faces/behavior/miniscope/miniscopedatainterface.py 100.00% <100.00%> (ø)
... and 61 more
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: use specific types for file and folder instead of aliases
2 participants