Fix and improved phpdocs check, reduced some log noise, add better options for future CI tweaking #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keevan
force-pushed
the
64-fix-phpdoc-checks
branch
from
11978ec to
504b092
Compare
- show relevant path (less noise) (phpdoc) - show only paths that have issues (phpdoc) - show less boring logs (via grouping) - add workflow branch options for testing different ci changes (ci)
keevan
force-pushed
the
64-fix-phpdoc-checks
branch
from
d143633 to
7a24215
Compare
keevan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #63
Resolves #64
Resolves #62
Tests performed for confirmation:
https://github.com/catalyst/moodle-tool_dataflows/runs/7644515755?check_suite_focus=true#step:4:856
Note that this was tested with everything pointed to "main" (reusable workflow) by default, but overriden using a custom branch option: https://github.com/catalyst/moodle-tool_dataflows/pull/396/files#r936206729