You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This should alleviate some annoyances when it comes to testing a workflow PR, because many of the references in ci.yml reference the main branch of the workflows.
This potentially could be another option provided to ci.yml but defaulting to main.
A better option would be to default to whatever the current reusable workflow branch it is currently on, but unsure if there's an option for that.
The text was updated successfully, but these errors were encountered:
keevan
changed the title
Update CI to by default, reference it's own calling branch, if not provide an option to test a different branch
Update CI to by default, reference it's own calling branch e.g. @main or @some-branch, if not provide an option to test a different branch
Jul 26, 2022
If what I just said sounded messy, it really was and so fixing this should make it so if you created a PR with some changes, you only need to point the CI at the PR branch, and it should just work.
Ultimately, it only worked in using what was available in the plugin repo, not the reusable one which was what I wanted instead. I combined a bit of this and that, and I believe I've found a mix that is "good enough" for now. It does require an option to be passed through, slightly redundant as there didn't seem to be any direct way of referencing that piece of information. A slightly better option considered was parsing the ci file that was called from the plugin, and wrangling the branch name out of the use line but that seems more likely to have issues, at least initially.
The changes will come in at the same time as the phpdoc fixes
This should alleviate some annoyances when it comes to testing a workflow PR, because many of the references in ci.yml reference the main branch of the workflows.
This potentially could be another option provided to ci.yml but defaulting to main.
A better option would be to default to whatever the current reusable workflow branch it is currently on, but unsure if there's an option for that.
The text was updated successfully, but these errors were encountered: