-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CR]Vehicle<->grid connector #322
Conversation
181d385
to
79a3109
Compare
@Coolthulhu are you going to enable power grid by default now or sometime later? |
Probably with this PR, but it might take a while to get it to work. |
ca863ec
to
9d14914
Compare
9d14914
to
783d0d9
Compare
Alright, this is pretty near completion. |
Support option to disable grid again
Grid->veh off-bubble now works Laser turrets can shoot from grid power Grids now report stored amount properly
OK, I fixed all the problems I could find. I tested it like this:
Plus there's some test backing, but less extensive than my manual test. It might be worth adding a long chain test, but this thing is already over 2 weeks old, so I'd rather just get it in and fix it later. Comments requested, especially code quality hints. |
Experimentally giving it a go |
A furniture part that connects a vehicle to a non-vehicle power grid.
Current limitations that need to be fixed:
vehicle::find_vehicle
(I wish I checked existing code first - it has exactly what I wanted)