Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading Data Values files in the same ways "ordinary" files are loaded #670

Merged
merged 3 commits into from
May 24, 2022

Commits on May 23, 2022

  1. Accept directory paths in ReadFilesFunc

    ... so that data values can be loaded via all the strategies that files
    are loaded from `--file`
    
    Also:
    - update the starting example to illustrate that all values are plain
      merged.
    - Share symlink options between files and DV options structs so that
      when the configuration is set, it's available to both
      RegularilesSourceOpts code and DataValuesFlag code.
    - Update help text with more broadly used file input formats.
    - Adjust some other help text to be more helpful.
    jtigger committed May 23, 2022
    Configuration menu
    Copy the full SHA
    e6a5d00 View commit details
    Browse the repository at this point in the history
  2. Make end-to-end tests more navigable

    ... so that as a contributor, when I read this list of tests, I can
    focus my attention to a section of the test file, rather than having to
    comprehend the whole thing at once.
    
    - group and sort by purpose
      - feature-specific tests, first
      - input/output mechanism verification, next
      - groups of examples-based tests for verifying the examples, last
    - add the "Overlay" Playground example group (currently untested)
    - add missing expectations for Overlay examples
    jtigger committed May 23, 2022
    Configuration menu
    Copy the full SHA
    c87dc85 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5d60337 View commit details
    Browse the repository at this point in the history