Support loading Data Values files in the same ways "ordinary" files are loaded #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotaljohn
force-pushed
the
data-values-dir
branch
from
92fc25f
to
126538f
Compare
pivotaljohn
changed the title
cppforlife
reviewed
May 19, 2022
cppforlife
reviewed
May 19, 2022
pivotaljohn
force-pushed
the
data-values-dir
branch
from
4415549
to
43f3048
Compare
pivotaljohn
force-pushed
the
data-values-dir
branch
from
43f3048
to
ca1e4c8
Compare
... so that data values can be loaded via all the strategies that files are loaded from `--file` Also: - update the starting example to illustrate that all values are plain merged. - Share symlink options between files and DV options structs so that when the configuration is set, it's available to both RegularilesSourceOpts code and DataValuesFlag code. - Update help text with more broadly used file input formats. - Adjust some other help text to be more helpful.
... so that as a contributor, when I read this list of tests, I can focus my attention to a section of the test file, rather than having to comprehend the whole thing at once. - group and sort by purpose - feature-specific tests, first - input/output mechanism verification, next - groups of examples-based tests for verifying the examples, last - add the "Overlay" Playground example group (currently untested) - add missing expectations for Overlay examples
pivotaljohn
force-pushed
the
data-values-dir
branch
from
ca1e4c8
to
5d60337
Compare
gcheadle-vmware
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing the strategy by which a filepath from
--fileis used to resolve to the contents of the file(s) for loading Data Values.All types of inputs are now supported (and handled identically) across
--file,--data-value-file, and--data-values-file: 🎉