Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Specify packages as ESM and extract common TS configs (#262)" #270

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

broody
Copy link
Contributor

@broody broody commented Apr 15, 2024

As discussed with @JunichiSugiura, reverting this for now.

Issue is Connect doesn't seem to work properly. Initial login/signup UI works, but controller is never in the connected state, so starknet-react example does not load.

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cartridge-starknet-react-next ✅ Ready (Inspect) Visit Preview Apr 15, 2024 8:39pm
docs ✅ Ready (Inspect) Visit Preview Apr 15, 2024 8:39pm
keychain ✅ Ready (Inspect) Visit Preview Apr 15, 2024 8:39pm
ui ✅ Ready (Inspect) Visit Preview Apr 15, 2024 8:39pm
ui-next ✅ Ready (Inspect) Visit Preview Apr 15, 2024 8:39pm

@broody broody merged commit 5ea4f52 into main Apr 15, 2024
8 checks passed
@broody broody deleted the revert-esm branch April 15, 2024 20:45
@JunichiSugiura JunichiSugiura mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant