Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify packages as ESM and extract common TS configs #262

Merged
merged 6 commits into from
Apr 11, 2024

Conversation

JunichiSugiura
Copy link
Collaborator

@JunichiSugiura JunichiSugiura commented Apr 11, 2024

  • Specify connector + controller as ES module
  • Move common ts config to tsconfig.base.json and tsconfig.react.json
  • Specify module resolution as Bundler

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cartridge-starknet-react-next ✅ Ready (Inspect) Visit Preview Apr 11, 2024 9:29pm
docs ✅ Ready (Inspect) Visit Preview Apr 11, 2024 9:29pm
keychain ✅ Ready (Inspect) Visit Preview Apr 11, 2024 9:29pm
ui ✅ Ready (Inspect) Visit Preview Apr 11, 2024 9:29pm
ui-next ✅ Ready (Inspect) Visit Preview Apr 11, 2024 9:29pm

@JunichiSugiura
Copy link
Collaborator Author

JunichiSugiura commented Apr 11, 2024

Getting this error while building get-starknet example.

SyntaxError: Cannot use import statement outside a module

react-scripts v5 seems to be the cause (ref).

@JunichiSugiura JunichiSugiura marked this pull request as ready for review April 11, 2024 12:11
@JunichiSugiura JunichiSugiura marked this pull request as draft April 11, 2024 13:34
@JunichiSugiura JunichiSugiura changed the title Specify connector and controller as ES6 module Specify connector and controller as ESM Apr 11, 2024
@JunichiSugiura JunichiSugiura marked this pull request as ready for review April 11, 2024 14:53
"types": [
"@emotion/react/types/css-prop"
]
],
// TODO(#262): Enable these options (too many errors for this scope)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit too much errors to fix in this scope but should be fixed asap. A lot of type errors has been surpressed.

@JunichiSugiura JunichiSugiura changed the title Specify connector and controller as ESM Specify packages as ESM and extract common ts configs Apr 11, 2024
@JunichiSugiura JunichiSugiura changed the title Specify packages as ESM and extract common ts configs Specify packages as ESM and extract common TS configs Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant