Fix #1064: handle firstseen as a reserved word
#1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we do something similar for |
No, because |
ramonpetgrave64
approved these changes
Jan 4, 2023
chandanchowdhury
pushed a commit
to juju4/cartography
that referenced
this pull request
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1064: Prevents
firstseenfrom being defined as part of CartographyNodeProperties and CartographyRelProperties objects because the querybuilder automatically sets it. Adds tests for EMR.I couldn't add a unit test for the
__post_init__because if I create a CartographyNodeProperties with afirstseenfield, the__post__init__gets run when the dataclass object is defined, which causes the TypeError to throw before any tests are able to run.