Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMRCluster node don't have firstseen property #1064

Closed
VishalAgarW opened this issue Dec 30, 2022 · 1 comment · Fixed by #1065
Closed

EMRCluster node don't have firstseen property #1064

VishalAgarW opened this issue Dec 30, 2022 · 1 comment · Fixed by #1065

Comments

@VishalAgarW
Copy link
Contributor

Title: EMRCluster node does not have firstseen property anymore

Description:
As part of #1038 change, EMRCluster node no longer has "firstseen" property. The problem is that "firstseen" is defined as explicit property in EMRClusterNodeProperties class
firstseen: PropertyRef = PropertyRef('firstseen')

during query building phase, this ends up getting translated as:
SET\n i.lastupdated = $lastupdated,\ni.arn = item.ClusterArn,\ni.auto_terminate = item.AutoTerminate,\ni.autoscaling_role = item.AutoScalingRole,\ni.custom_ami_id = item.CustomAmiId,\ni.firstseen = item.firstseen,

however since the item doesn't have firstseen property, it gets reset to None and the original timestamp (set via ON CREATE SET) is lost.

To Reproduce:

  1. Run cartography against an account that has EMR setup and then review the EMRCluster node.
@achantavy
Copy link
Contributor

however since the item doesn't have firstseen property, it gets reset to None and the original timestamp (set via ON CREATE SET) is lost.

D'oh. Thank you for the bug report! Fixing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants