-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fixes needed for focal support. #1704
Conversation
Signed-off-by: Wolfgang Hess <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me.
Wait, you are allowed to return by value an lvalue |
@ojura See https://en.cppreference.com/w/cpp/language/return or https://isocpp.org/blog/2013/02/no-really-moving-a-return-value-is-easy-stackoverflow: Removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Wolfgang Hess <[email protected]>
Signed-off-by: Wolfgang Hess <[email protected]>
thanks! |
Signed-off-by: Wolfgang Hess [email protected]