Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GitHub Actions] 'Website' workflow keeps deleted files in gh-pages branch #544

Open
fmichonneau opened this issue Feb 8, 2021 · 1 comment
Open

[GitHub Actions] 'Website' workflow keeps deleted files in gh-pages branch #544

fmichonneau opened this issue Feb 8, 2021 · 1 comment
Assignees
@zkamvar

Comments

@fmichonneau
Copy link
Contributor

fmichonneau commented Feb 8, 2021 •
edited
Loading

As gh-pages isn't an orphaned branch anymore, files that are deleted in main remain in the rendered version in gh-pages. The workflow needs to be adapted to make sure these files are also removed.
@fmichonneau fmichonneau changed the title [GitHub Actions] " [GitHub Actions] 'Website' workflow keeps deleted files in gh-pages branch Feb 8, 2021
@zkamvar
Copy link
Contributor

zkamvar commented Feb 8, 2021

This is a good point, and I believe it is relevant with the {sandpaper} workflows as well.

zkamvar added a commit to zkamvar/styles that referenced this issue Feb 8, 2021
@zkamvar
add patch to clean gh-pages before committing
ed29df3 
This will address carpentries#544
@zkamvar zkamvar mentioned this issue Feb 8, 2021
Merged
fmichonneau pushed a commit that referenced this issue Feb 10, 2021
@zkamvar
add patch to clean gh-pages before committing (#545)
d021e1f 
This will address #544
@tobyhodges tobyhodges mentioned this issue Jul 19, 2022
Closed
@dan-zeman dan-zeman mentioned this issue Sep 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zkamvar zkamvar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zkamvar @fmichonneau