Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed files are not removed from gh-pages branch on website build #79

Closed
alanocallaghan opened this issue Jul 19, 2022 · 3 comments · Fixed by #80
Closed

Renamed files are not removed from gh-pages branch on website build #79

alanocallaghan opened this issue Jul 19, 2022 · 3 comments · Fixed by #80

Comments

@alanocallaghan
Copy link
Collaborator

See discussion in #77

@alanocallaghan
Copy link
Collaborator Author

I think it's down to this part of the gh actions build recipe:

https://github.com/Alanocallaghan/high-dimensional-stats-r/blob/f3256c0ff20198533a0d1bc6b866e86102097b4b/.github/workflows/website.yml#L93-L109

Basically it doesn't merge the commits that delete the files, so it'll only ever add content and never remove. You'd have to merge main into gh-pages and push that which is kinda redundant. Will see what other jekyll sites use instead, surely this isn't the right way to go

@tobyhodges
Copy link
Member

I remember running into this myself in the past, and indeed an issue was opened in Feb last year to report it: carpentries/styles#544 Looks like @zkamvar made a fix in carpentries/styles#545 - might this work for you here as well?

@catavallejos
Copy link
Collaborator

Thanks for the suggestion. I edited our website.ylm to see if this helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants