Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Improve fuzzy search #303

Merged
merged 2 commits into from
Feb 3, 2020

Conversation

adriencaccia
Copy link
Contributor

Description

This PR does 2 things:

  • Add a lower threshold (from the 0.6 default to 0.5) to the Fuse.js search options on the gitmojis to better match what the user is trying to get
  • Improve the filterGitmoji.spec.js test suite to directly test the filter on real life use cases

Issue: #302

Tests

  • All tests passed.

@codecov
Copy link

codecov bot commented Feb 2, 2020

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files          21       21           
  Lines         142      142           
  Branches       21       21           
=======================================
  Hits          125      125           
  Misses         14       14           
  Partials        3        3
Impacted Files Coverage Δ
src/utils/filterGitmojis.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d202b85...57acfac. Read the comment docs.

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks 👏

@carloscuesta carloscuesta merged commit 4bbc71a into carloscuesta:master Feb 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants