Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy search should sort more intelligently / by relevance #302

Closed
erikhuizinga opened this issue Feb 2, 2020 · 1 comment
Closed

Fuzzy search should sort more intelligently / by relevance #302

erikhuizinga opened this issue Feb 2, 2020 · 1 comment
Labels

Comments

@erikhuizinga
Copy link

Hello @carloscuesta!

Fuzzy search, introduced by πŸ”– v3.2.0 πŸŽ‰ (thanks, awesome feature!), shows search results in a seemingly strange order.

Issue:

  1. gitmoji -c
  2. Start typing 'test' (to find βœ…) character by character:
    1. image
    2. image
    3. image
    4. image

Notice that βœ… is not found in the last search result, while the word 'test' is almost a direct match with a word in 'updating tests'. As a user I expect the search results to be sorted by relevance, with larger partial word matches having greater relevance.

OS: macOS 10.14.6
gitmoji-cli -v: 3.2.0
Node version: node -v: v13.7.0

Error Message: none

See aforementioned issues steps.

@adriencaccia
Copy link
Contributor

Hey @erikhuizinga, thanks for the issue !
I submitted #303 to try and improve the search.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants